Skip to content

Drop Requires.jl dependency and use native Julia v1.10 extensions #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop Requires.jl dependency and use native Julia v1.10 extensions #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6'
- '1.7'
- '1.8'
- '1.9'
- '1.10'
- '1.11'
- 'nightly'
Expand Down
4 changes: 1 addition & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ version = "4.4.0"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Requires = "ae029012-a4dd-5104-9daa-d747884805df"

[weakdeps]
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Expand All @@ -15,9 +14,8 @@ AdaptSparseArraysExt = "SparseArrays"
AdaptStaticArraysExt = "StaticArrays"

[compat]
Requires = "1"
StaticArrays = "1"
julia = "1.6"
julia = "1.10"
LinearAlgebra = "1"
SparseArrays = "1"

Expand Down
2 changes: 1 addition & 1 deletion ext/AdaptSparseArraysExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module AdaptSparseArraysExt

using Adapt
isdefined(Base, :get_extension) ? (using SparseArrays) : (using ..SparseArrays)
using SparseArrays

Adapt.adapt_storage(::Type{Array}, xs::SparseVector) = xs
Adapt.adapt_storage(::Type{Array}, xs::SparseMatrixCSC) = xs
Expand Down
2 changes: 1 addition & 1 deletion ext/AdaptStaticArraysExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module AdaptStaticArraysExt

using Adapt
isdefined(Base, :get_extension) ? (using StaticArrays) : (using ..StaticArrays)
using StaticArrays

Adapt.adapt_storage(::Type{<:SArray{S}}, xs::Array) where {S} = SArray{S}(xs)
Adapt.adapt_storage(::Type{SArray}, xs::Array) = SArray{Tuple{size(xs)...}}(xs)
Expand Down
14 changes: 0 additions & 14 deletions src/Adapt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,19 +67,5 @@ include("arrays.jl")
# helpers
include("macro.jl")

if !isdefined(Base, :get_extension)
using Requires
end

@static if !isdefined(Base, :get_extension)
function __init__()
@require SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" begin
include("../ext/AdaptSparseArraysExt.jl")
end
@require StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" begin
include("../ext/AdaptStaticArraysExt.jl")
end
end
end

end # module
Loading