Skip to content

Simplify specifying benchmark output file #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025
+2 −1
Merged

Simplify specifying benchmark output file #2814

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f9b6e3
Simplify specifying benchmark output file
christiangnrd Jul 20, 2025
c618a30
Remove tag
christiangnrd Jul 23, 2025
1942eb2
Accept alternate filename as optional argument
christiangnrd Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions perf/runbenchmarks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,16 @@ macro async_benchmarkable(ex...)
end
end

if !@isdefined(BENCHOUT)
BENCHOUT = "benchmarkresults.json"
end

# before anything else, run latency benchmarks. these spawn subprocesses, so we don't want
# to do so after regular benchmarks have caused the memory allocator to reserve memory.
@info "Running latency benchmarks"
latency_results = include("latency.jl")

SUITE = BenchmarkGroup()
SUITE = BenchmarkGroup([BENCHOUT])

include("cuda.jl")
include("kernel.jl")
Expand Down Expand Up @@ -50,4 +54,4 @@ results["latency"] = latency_results
results["integration"] = integration_results

# write out the results
BenchmarkTools.save("benchmarkresults.json", median(results))
BenchmarkTools.save(BENCHOUT, median(results))