-
Notifications
You must be signed in to change notification settings - Fork 244
Test GPUArrays reverse
#2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christiangnrd
wants to merge
3
commits into
JuliaGPU:master
Choose a base branch
from
christiangnrd:rev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Test GPUArrays reverse
#2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/perf/array.jl b/perf/array.jl
index 178cb4661..fc335cf2c 100644
--- a/perf/array.jl
+++ b/perf/array.jl
@@ -54,11 +54,11 @@ let group = addgroup!(group, "reverse")
group["1d"] = @async_benchmarkable reverse($gpu_vec)
group["1dL"] = @async_benchmarkable reverse($gpu_vec_long)
group["2d"] = @async_benchmarkable reverse($gpu_mat; dims=1)
- group["2dL"] = @async_benchmarkable reverse($gpu_mat_long; dims=1)
+ group["2dL"] = @async_benchmarkable reverse($gpu_mat_long; dims = 1)
group["1d_inplace"] = @async_benchmarkable reverse!($gpu_vec)
group["1dL_inplace"] = @async_benchmarkable reverse!($gpu_vec_long)
group["2d_inplace"] = @async_benchmarkable reverse!($gpu_mat; dims=1)
- group["2dL_inplace"] = @async_benchmarkable reverse!($gpu_mat_long; dims=2)
+ group["2dL_inplace"] = @async_benchmarkable reverse!($gpu_mat_long; dims = 2)
end
# group["broadcast"] = @async_benchmarkable $gpu_mat .= 0f0
diff --git a/perf/runbenchmarks.jl b/perf/runbenchmarks.jl
index f66a1a8a9..4ab88b998 100644
--- a/perf/runbenchmarks.jl
+++ b/perf/runbenchmarks.jl
@@ -1,6 +1,6 @@
# benchmark suite execution and codespeed submission
using Pkg
-Pkg.add(url="https://github.com/christiangnrd/GPUArrays.jl", rev="reverse")
+Pkg.add(url = "https://github.com/christiangnrd/GPUArrays.jl", rev = "reverse")
using CUDA
diff --git a/test/runtests.jl b/test/runtests.jl
index 8aa8a9d69..cf9ef8cfd 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -1,5 +1,5 @@
using Pkg
-Pkg.add(url="https://github.com/christiangnrd/GPUArrays.jl", rev="reverse")
+Pkg.add(url = "https://github.com/christiangnrd/GPUArrays.jl", rev = "reverse")
using Distributed
using Dates |
b9d6112
to
8e44b5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA.jl Benchmarks
Benchmark suite | Current: ab7c713 | Previous: 205c238 | Ratio |
---|---|---|---|
array/reverse/1d |
23056 ns |
20143 ns |
1.14 |
array/reverse/2d |
28198 ns |
24692 ns |
1.14 |
array/reverse/1d_inplace |
13399 ns |
11332 ns |
1.18 |
array/reverse/2d_inplace |
15169 ns |
13662 ns |
1.11 |
This comment was automatically generated by workflow using github-action-benchmark.
cd686cc
to
f2039c8
Compare
[only julia] [only benchmarks]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[only julia]
[only benchmarks]