Link target library late, to avoid bloat during primary optimization #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The NVPTX back-end user guide instructs to optimize after linking libdevice: https://llvm.org/docs/NVPTXUsage.html#linking-with-libdevice |
maleadt
force-pushed
the
master
branch
5 times, most recently
from
1d233d7 to
e18b7c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by a conversation with @pmccormick, @neboat, and @stelleg.
Based of the benchmark code https://gist.github.com/vchuravy/7d639aedd98c51d32541ae999504685a, it's not yet behavioral identical to the C++ code in https://github.com/pmccormick/kitsune/blob/ea8ab2916f043a8b33bc20c1c1ec4f280a8f6c1d/kitsune/experiments/raytracer/raytrace-kokkos.cpp but currently performance seems to be not matching NVCC Pat also wrote a CUDA version in https://github.com/pmccormick/kitsune/blob/dev/12.x/kitsune/experiments/raytracer/raytrace-cuda.cu as a baseline