Skip to content

Add exceptions to check_ir_values #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 21, 2024
Merged

Add exceptions to check_ir_values #630

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
809940d
add ir_check_ignore metadata to check ir type check
tgymnich Sep 17, 2024
b5e13ac
allow fpext for metal
tgymnich Sep 18, 2024
fe80530
Revert "allow fpext for metal"
tgymnich Sep 20, 2024
9a2535e
Revert "add ir_check_ignore metadata to check ir type check"
tgymnich Sep 20, 2024
9ed1583
use callback to check for doubles used in logging
tgymnich Sep 20, 2024
2cc6241
improve callback
tgymnich Sep 20, 2024
8c6e38c
add tests
tgymnich Sep 20, 2024
b77553c
NFC clean-up.
maleadt Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/metal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function validate_ir(job::CompilerJob{MetalCompilerTarget}, mod::LLVM.Module)
errors = IRError[]

# Metal never supports double precision
append!(errors, check_ir_values(mod, LLVM.DoubleType()))
append!(errors, check_ir_values(mod, LLVM.DoubleType(), allow=(LLVM.FPExtInst,)))
append!(errors, check_ir_values(mod, LLVM.IntType(128)))

errors
Expand Down
19 changes: 15 additions & 4 deletions src/validation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,14 +318,25 @@ function check_ir!(job, errors::Vector{IRError}, inst::LLVM.CallInst)
end

# helper function to check if a LLVM module uses values of a certain type
function check_ir_values(mod::LLVM.Module, T_bad::LLVMType)
function check_ir_values(mod::LLVM.Module, T_bad::LLVMType; allow=())
errors = IRError[]

for fun in functions(mod), bb in blocks(fun), inst in instructions(bb)
if value_type(inst) == T_bad || any(param->value_type(param) == T_bad, operands(inst))
bt = backtrace(inst)
push!(errors, ("use of $(string(T_bad)) value", bt, inst))
if typeof(inst) in allow
continue
end

if haskey(metadata(inst), "ir_check_ignore")
continue
end

if value_type(inst) != T_bad &&
all(op -> value_type(op) != T_bad || (op isa Instruction && haskey(metadata(op), "ir_check_ignore")), operands(inst))
continue
end

bt = backtrace(inst)
push!(errors, ("use of $(string(T_bad)) value", bt, inst))
end

return errors
Expand Down