Adapt to latest binding change in 1.12#681
Merged
maleadt merged 1 commit intoJuliaGPU:masterfrom Mar 25, 2025
Merged
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/validation.jl b/src/validation.jl
index 5af965e..8f73a79 100644
--- a/src/validation.jl
+++ b/src/validation.jl
@@ -239,7 +239,7 @@ function check_ir!(job, errors::Vector{IRError}, inst::LLVM.CallInst)
push!(errors, (DELAYED_BINDING, bt, nothing))
end
elseif fn == "jl_reresolve_binding_value_seqcst" || fn == "ijl_reresolve_binding_value_seqcst" ||
- fn == "jl_get_binding_value_seqcst" || fn == "ijl_get_binding_value_seqcst"
+ fn == "jl_get_binding_value_seqcst" || fn == "ijl_get_binding_value_seqcst"
try
# pry the binding from the IR
expr = arguments(inst)[1]::ConstantExpr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
+ Coverage 65.19% 68.27% +3.07%
==========================================
Files 24 24
Lines 3451 3451
==========================================
+ Hits 2250 2356 +106
+ Misses 1201 1095 -106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may want to clean this up whenever the binding stuff finally stabilizes