-
Notifications
You must be signed in to change notification settings - Fork 59
Derive compile config for runtime correctly #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/rtlib.jl b/src/rtlib.jl
index 1d8c00f..a164382 100644
--- a/src/rtlib.jl
+++ b/src/rtlib.jl
@@ -99,7 +99,7 @@ function build_runtime(@nospecialize(job::CompilerJob))
# the compiler job passed into here is identifies the job that requires the runtime.
# derive a job that represents the runtime itself (notably with kernel=false).
- config = CompilerConfig(job.config; kernel=false, toplevel=false, only_entry=false, strip=false)
+ config = CompilerConfig(job.config; kernel = false, toplevel = false, only_entry = false, strip = false)
for method in values(Runtime.methods)
def = if isa(method.def, Symbol) |
.buildkite/pipeline.yml
Outdated
| using Pkg | ||
| Pkg.develop(; path=pwd()) | ||
| Pkg.develop(; name="AMDGPU")' || exit 3 | ||
| Pkg.add(; name="AMDGPU", rev="pxl-th/debug")' || exit 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this before merging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
- Coverage 68.27% 66.53% -1.74%
==========================================
Files 24 24
Lines 3451 3451
==========================================
- Hits 2356 2296 -60
- Misses 1095 1155 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maleadt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feel free to merge when the temporary CI hacks have been removed.
|
Reverted CI, but it will fail at the moment, because AMDGPU has a compat bound. |
|
Let's merge and tag. |
#668 (comment)