Skip to content

Conversation

@pxl-th
Copy link
Member

@pxl-th pxl-th commented Mar 27, 2025

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/rtlib.jl b/src/rtlib.jl
index 1d8c00f..a164382 100644
--- a/src/rtlib.jl
+++ b/src/rtlib.jl
@@ -99,7 +99,7 @@ function build_runtime(@nospecialize(job::CompilerJob))
 
     # the compiler job passed into here is identifies the job that requires the runtime.
     # derive a job that represents the runtime itself (notably with kernel=false).
-    config = CompilerConfig(job.config; kernel=false, toplevel=false, only_entry=false, strip=false)
+    config = CompilerConfig(job.config; kernel = false, toplevel = false, only_entry = false, strip = false)
 
     for method in values(Runtime.methods)
         def = if isa(method.def, Symbol)

using Pkg
Pkg.develop(; path=pwd())
Pkg.develop(; name="AMDGPU")' || exit 3
Pkg.add(; name="AMDGPU", rev="pxl-th/debug")' || exit 3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this before merging

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.53%. Comparing base (aaad5ba) to head (5860d2a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/rtlib.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   68.27%   66.53%   -1.74%     
==========================================
  Files          24       24              
  Lines        3451     3451              
==========================================
- Hits         2356     2296      -60     
- Misses       1095     1155      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pxl-th pxl-th self-assigned this Mar 27, 2025
@pxl-th pxl-th added bug Something isn't working gcn Stuff about the AMD GCN back-end. labels Mar 27, 2025
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge when the temporary CI hacks have been removed.

@pxl-th
Copy link
Member Author

pxl-th commented Mar 28, 2025

Reverted CI, but it will fail at the moment, because AMDGPU has a compat bound.

@maleadt
Copy link
Member

maleadt commented Mar 28, 2025

Let's merge and tag.

@maleadt maleadt merged commit 5b07695 into master Mar 28, 2025
21 of 22 checks passed
@maleadt maleadt deleted the pxl-th/fix branch March 28, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gcn Stuff about the AMD GCN back-end.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants