Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/rtlib.jl b/src/rtlib.jl
index 1d8c00f..a164382 100644
--- a/src/rtlib.jl
+++ b/src/rtlib.jl
@@ -99,7 +99,7 @@ function build_runtime(@nospecialize(job::CompilerJob))
# the compiler job passed into here is identifies the job that requires the runtime.
# derive a job that represents the runtime itself (notably with kernel=false).
- config = CompilerConfig(job.config; kernel=false, toplevel=false, only_entry=false, strip=false)
+ config = CompilerConfig(job.config; kernel = false, toplevel = false, only_entry = false, strip = false)
for method in values(Runtime.methods)
def = if isa(method.def, Symbol) |
pxl-th
commented
Mar 27, 2025
.buildkite/pipeline.yml
Outdated
| using Pkg | ||
| Pkg.develop(; path=pwd()) | ||
| Pkg.develop(; name="AMDGPU")' || exit 3 | ||
| Pkg.add(; name="AMDGPU", rev="pxl-th/debug")' || exit 3 |
Member
Author
There was a problem hiding this comment.
Need to remove this before merging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
- Coverage 68.27% 66.53% -1.74%
==========================================
Files 24 24
Lines 3451 3451
==========================================
- Hits 2356 2296 -60
- Misses 1095 1155 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maleadt
approved these changes
Mar 28, 2025
Member
maleadt
left a comment
There was a problem hiding this comment.
Thanks! Feel free to merge when the temporary CI hacks have been removed.
Member
Author
|
Reverted CI, but it will fail at the moment, because AMDGPU has a compat bound. |
Member
|
Let's merge and tag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#668 (comment)