Skip to content

switch SPIR-V backend from LLVM to Khronos #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

simeonschaub
Copy link
Contributor

@maleadt
Copy link
Member

maleadt commented Aug 12, 2025

That doesn't need a change here, OpenCL.jl can simply pass a different backend flag here: https://github.com/JuliaGPU/OpenCL.jl/blob/7a7b8e92c95717b65e0696b0c0f6205131b29e4a/src/compiler/compilation.jl#L52

That said, with #709 being uncertain (see #709 (comment)) the change isn't strictly necessary anymore. I'm not sure yet how we'll get out of this yet, maybe it's best to switch PoCL over to CBS for now (pocl/pocl#1974) and use arm_terminate_kernel once PoCL supports cl_arm_controlled_kernel_termination.

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.33%. Comparing base (32b4fc8) to head (b230a7e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   75.27%   75.33%   +0.05%     
==========================================
  Files          24       24              
  Lines        3523     3523              
==========================================
+ Hits         2652     2654       +2     
+ Misses        871      869       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simeonschaub
Copy link
Contributor Author

I was more concerned with JuliaGPU/OpenCL.jl#353 here, but I see your point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants