[Metal] Add some simdgroup and barrier intrinsic attributes#744
Merged
christiangnrd merged 1 commit intoJuliaGPU:masterfrom Jan 13, 2026
Merged
[Metal] Add some simdgroup and barrier intrinsic attributes#744christiangnrd merged 1 commit intoJuliaGPU:masterfrom
christiangnrd merged 1 commit intoJuliaGPU:masterfrom
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/metal.jl b/src/metal.jl
index 6f1749e..a79dec1 100644
--- a/src/metal.jl
+++ b/src/metal.jl
@@ -1034,7 +1034,7 @@ function annotate_air_intrinsics!(@nospecialize(job::CompilerJob), mod::LLVM.Mod
# TODO: "memory(argmem: readwrite)" on LLVM 16+
add_attributes("argmemonly", "nounwind")
- # simdgroup
+ # simdgroup
elseif match(r"air.simdgroup_matrix_8x8_multiply_accumulate", fn) !== nothing
add_attributes("convergent", "mustprogress", "nounwind", "willreturn")
elseif match(r"air.simdgroup_matrix_8x8_load", fn) !== nothing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 74.79% 74.75% -0.05%
==========================================
Files 24 24
Lines 3666 3672 +6
==========================================
+ Hits 2742 2745 +3
- Misses 924 927 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maleadt
reviewed
Nov 24, 2025
maleadt
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds simdgroup and barrier function attributes