Skip to content

KI docstring typos #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vchuravy merged 1 commit into from
Nov 22, 2025
Merged

KI docstring typos #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/intrinsics.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ macro kernel(backend, ex...)
end

# destructure the kernel call
Meta.isexpr(call, :call) || throw(ArgumentError("final argument to @kikern should be a function call"))
Meta.isexpr(call, :call) || throw(ArgumentError("final argument to KI.@kernel should be a function call"))
f = call.args[1]
args = call.args[2:end]

Expand All @@ -330,14 +330,14 @@ macro kernel(backend, ex...)
for kwarg in macro_kwargs
key, val = kwarg.args
if key === :launch
isa(val, Bool) || throw(ArgumentError("`launch` keyword argument to @kikern should be a Bool"))
isa(val, Bool) || throw(ArgumentError("`launch` keyword argument to KI.@kernel should be a Bool"))
launch = val::Bool
else
throw(ArgumentError("Unsupported keyword argument '$key'"))
end
end
if !launch && !isempty(call_kwargs)
error("@kikern with launch=false does not support launch-time keyword arguments; use them when calling the kernel")
error("KI.@kernel with launch=false does not support launch-time keyword arguments; use them when calling the kernel")
end

# FIXME: macro hygiene wrt. escaping kwarg values (this broke with 1.5)
Expand Down
Loading