Skip to content

Use Enums to make it easier to reason about constants#60

Open
vchuravy wants to merge 2 commits intomainfrom
vc/enums
Open

Use Enums to make it easier to reason about constants#60
vchuravy wants to merge 2 commits intomainfrom
vc/enums

Conversation

@vchuravy
Copy link
Copy Markdown
Member

@vchuravy vchuravy commented Apr 1, 2026

No description provided.

message_type = NVTX_MESSAGE_TYPE_REGISTERED
message = message.ptr
else
message_type = NVTX_MESSAGE_TYPE_ASCII
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass Unicode?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to pass utf8, but not sure if it's officially supported

@maleadt
Copy link
Copy Markdown
Member

maleadt commented Apr 1, 2026

Should probably revert JuliaGPU/CUDA.jl#3075 then

@vchuravy
Copy link
Copy Markdown
Member Author

vchuravy commented Apr 1, 2026

Should probably revert JuliaGPU/CUDA.jl#3075 then

I don't think so... The enuma in the NVTX headers match the old integers constants, so I would expect to still see the same behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants