Skip to content

1.12 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 23, 2025
Merged

1.12 #391

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b28270e
switch CI to 1.12
simeonschaub Oct 13, 2025
f98c613
try with the khronos backend
simeonschaub Oct 15, 2025
41a704a
Silence warning
christiangnrd Oct 15, 2025
96b01c3
No 7.1 yet and include 1.11, jll only
christiangnrd Oct 15, 2025
88a1be6
Revert "try with the khronos backend"
christiangnrd Oct 15, 2025
4932673
1.12 checkbounds fix
christiangnrd Oct 15, 2025
73303d3
Update quirks.jl
christiangnrd Oct 20, 2025
475a6a4
Revert "No 7.1 yet and include 1.11, jll only"
christiangnrd Oct 20, 2025
77328d1
Update src/device/quirks.jl
christiangnrd Oct 20, 2025
e3d681d
Apply suggestion from @christiangnrd
christiangnrd Oct 20, 2025
210e545
Disable Float16 tests
christiangnrd Oct 20, 2025
7a58c51
Disable Float16 only on pocl 7.1
christiangnrd Oct 20, 2025
56d7000
Update test/setup.jl
simeonschaub Oct 21, 2025
7434a60
Don’t test 1.11
christiangnrd Oct 21, 2025
70e66c1
Try with more time
christiangnrd Oct 21, 2025
59ec314
Even more time
christiangnrd Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ steps:
- label: "CUDA"
plugins:
- JuliaCI/julia#v1:
version: "1.11"
version: "1.12"
- JuliaCI/julia-coverage#v1:
codecov: true
commands: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['1.10', '1.11']
version: ['1.10', '1.11', '1.12']
os: [ubuntu-24.04, ubuntu-24.04-arm, macOS-15, macOS-15-intel, windows-2025]
arch: [x64, arm64]
pocl: [jll, local]
Expand Down
9 changes: 9 additions & 0 deletions src/device/quirks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,12 @@ end
@print_and_throw "Out-of-bounds access of scalar value"
x
end

# From Metal.jl to avoid widemul and Int128
@static if VERSION >= v"1.12.0-DEV.1736" # Partially reverts JuliaLang/julia PR #56750
BitInteger64 = Union{Int64, UInt64}
@device_override function Base.checkbounds(::Type{Bool}, v::StepRange{<:BitInteger64, <:BitInteger64}, i::BitInteger64)
@inline
return checkindex(Bool, eachindex(IndexLinear(), v), i)
end
end
12 changes: 10 additions & 2 deletions test/device.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,19 @@
:max_image3d_shape,
]
@test isa(cl.platform(), cl.Platform)
@test_throws ErrorException cl.platform().zjdlkf
if isdefined(Core, :FieldError) # VERSION > v"1.12.0-"
@test_throws FieldError cl.platform().zjdlkf
else
@test_throws ErrorException cl.platform().zjdlkf
end

device = cl.device()
@test isa(device, cl.Device)
@test_throws ErrorException device.zjdlkf
if isdefined(Core, :FieldError) # VERSION > v"1.12.0-"
@test_throws FieldError device.zjdlkf
else
@test_throws ErrorException device.zjdlkf
end
for k in device_info_keys
v = getproperty(device, k)
if k == :extensions
Expand Down
2 changes: 1 addition & 1 deletion test/setup.jl
View file
Open in desktop
Copy link
Member

@simeonschaub simeonschaub Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to disable Float16 tests for the local pocl builds though, those should actually pass

Copy link
Member Author

@christiangnrd christiangnrd Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing which is what I was testing

Copy link
Member

@simeonschaub simeonschaub Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PoCL local ones passed, e.g. https://github.com/JuliaGPU/OpenCL.jl/actions/runs/18655258708/job/53182708923

Copy link
Member Author

@christiangnrd christiangnrd Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only on 1.10 and 1.11 though, not 1.12

Copy link
Member

@simeonschaub simeonschaub Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the 1.12 failures are not due to Float16, they're #384 as I wrote earlier. Once the SPIRV-LLVM-Backend jll has been registered we can retrigger CI

Copy link
Member Author

@christiangnrd christiangnrd Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand now thank you for bearing with me. I'll push a change to skip float16 only on pocl_jll and to revert to using spirv_llvm_translator as soon as it's registered

Copy link
Member

@simeonschaub simeonschaub Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant SPIRV-LLVM-Backend, not translator, so that part is already correct. I was just experimenting with the khronos translator, but it's still pretty broken atm

Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function GPUArraysTestSuite.supported_eltypes(::Type{<:CLArray})
push!(types, Float64)
push!(types, ComplexF64)
end
if "cl_khr_fp16" in cl.device().extensions
if "cl_khr_fp16" in cl.device().extensions && !contains(cl.platform().version, "7.1")
push!(types, Float16)
push!(types, ComplexF16)
end
Expand Down