Skip to content

Conversation

@simeonschaub
Copy link
Member

Previously, the default method would widen to Int128 causing
compilation failures

Previously, the default method would widen to `Int128` causing
compilation failures
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/device/random.jl b/src/device/random.jl
index aa2cf7d..04a1c0e 100644
--- a/src/device/random.jl
+++ b/src/device/random.jl
@@ -233,5 +233,7 @@ end
     @invoke Random.randexp(rng::AbstractRNG, T::Type{<:AbstractFloat})
 end
 
-@device_override Random.Sampler(::Type{<:AbstractRNG}, r::AbstractUnitRange{T},
-                                ::Random.Repetition) where {T<:Union{Int64, UInt64}} = Random.SamplerRangeFast(r)
+@device_override Random.Sampler(
+    ::Type{<:AbstractRNG}, r::AbstractUnitRange{T},
+    ::Random.Repetition
+) where {T <: Union{Int64, UInt64}} = Random.SamplerRangeFast(r)
diff --git a/test/device/random.jl b/test/device/random.jl
index 6fef392..93e2032 100644
--- a/test/device/random.jl
+++ b/test/device/random.jl
@@ -147,8 +147,8 @@ end
     a = OpenCL.zeros(T, n)
     b = OpenCL.zeros(T, n)
 
-    @opencl global_size=n local_size=n kernel(a, seed)
-    @opencl global_size=n local_size=n kernel(b, seed)
+    @opencl global_size = n local_size = n kernel(a, seed)
+    @opencl global_size = n local_size = n kernel(b, seed)
 
     if seed === nothing || seed === missing
         @test Array(a) != Array(b)

simeonschaub added a commit to simeonschaub/Metal.jl that referenced this pull request Nov 6, 2025
Previously, the default method would widen to `Int128` causing
compilation failures

ref JuliaGPU/OpenCL.jl#402
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.19%. Comparing base (b18f78a) to head (01bf354).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   80.19%   80.19%           
=======================================
  Files          12       12           
  Lines         722      722           
=======================================
  Hits          579      579           
  Misses        143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

christiangnrd pushed a commit to simeonschaub/Metal.jl that referenced this pull request Nov 6, 2025
Previously, the default method would widen to `Int128` causing
compilation failures

ref JuliaGPU/OpenCL.jl#402
maleadt pushed a commit to JuliaGPU/Metal.jl that referenced this pull request Nov 7, 2025
Previously, the default method would widen to `Int128` causing
compilation failures

ref JuliaGPU/OpenCL.jl#402
@simeonschaub simeonschaub enabled auto-merge (squash) November 7, 2025 12:11
@simeonschaub simeonschaub merged commit 8a1785f into master Nov 7, 2025
28 of 37 checks passed
@simeonschaub simeonschaub deleted the sds/rand_range branch November 7, 2025 12:13
christiangnrd pushed a commit to JuliaGPU/Metal.jl that referenced this pull request Dec 3, 2025
Previously, the default method would widen to `Int128` causing
compilation failures

ref JuliaGPU/OpenCL.jl#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants