-
Notifications
You must be signed in to change notification settings - Fork 31
Complex Sparse CSC #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex Sparse CSC #528
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
|
For the complex cases, I can also post a warning that performance is degraded due to additional allocation. I think it might still be valuable in some cases. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 80.01% 79.37% -0.64%
==========================================
Files 45 45
Lines 2887 2972 +85
==========================================
+ Hits 2310 2359 +49
- Misses 577 613 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@michel2323 Is it fine for you to merge my PR before and then rebase your PR on top of it? |
9040ac3 to
dabcbd3
Compare
dabcbd3 to
34bd06d
Compare
@amontoison Sorry, I also worked on it yesterday 🙂. This support Complex and throws errors for the trsm etc.