Skip to content

Conversation

@michel2323
Copy link
Member

@amontoison Sorry, I also worked on it yesterday 🙂. This support Complex and throws errors for the trsm etc.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@michel2323
Copy link
Member Author

For the complex cases, I can also post a warning that performance is degraded due to additional allocation. I think it might still be valuable in some cases.

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 57.64706% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.37%. Comparing base (b79926a) to head (1066b17).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/mkl/wrappers_sparse.jl 57.64% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   80.01%   79.37%   -0.64%     
==========================================
  Files          45       45              
  Lines        2887     2972      +85     
==========================================
+ Hits         2310     2359      +49     
- Misses        577      613      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison
Copy link
Member

@michel2323 Is it fine for you to merge my PR before and then rebase your PR on top of it?
It will be easier to review for me.

@michel2323 michel2323 changed the title Sparse CSC Complex Sparse CSC Sep 24, 2025
@michel2323 michel2323 merged commit ad72a8a into master Sep 25, 2025
2 checks passed
@michel2323 michel2323 deleted the ms/csc_sparse branch September 25, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants