Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 96.21% 96.33% +0.12%
==========================================
Files 12 13 +1
Lines 396 491 +95
==========================================
+ Hits 381 473 +92
- Misses 15 18 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Very happy to give this a review -- when you're ready for one, please do tag me. |
Member
Author
|
@willtebbutt If you have some time, I would already appreciate a rough review, on the overall structure/ idea. |
yebai
reviewed
May 28, 2025
| FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b" | ||
| IrrationalConstants = "92d709cd-6900-40b7-9082-c6be49f344b6" | ||
| KernelFunctions = "ec8451be-7e33-11e9-00cf-bbf324bd1392" | ||
| KernelSpectralDensities = "027d52a2-76e5-4228-9bfe-bc7e0f5a8348" |
Contributor
There was a problem hiding this comment.
Can you move this into a package extension?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a (at this stage) draft PR to allow sampling of GP, including sampling via Cholesky, via Random Fourier Features, and pathwise/ decoupled sampling.
Proposed changes
The main interface revolves around a new
GPSamplerstruct, as a subtype ofRandom.Sampler, which takes a GP and a "method". One can then draw from this sampler usingrand`.However, there are still issues to this implementation
What alternatives have you considered?
Making a separate package, and/or (due to the complexity) just keeping it good enough for my needs.
Breaking changes
Should not be breaking (at this point).