-
Notifications
You must be signed in to change notification settings - Fork 6
Add unified interface test utils #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 70.58% 76.47% +5.88%
==========================================
Files 5 5
Lines 17 17
==========================================
+ Hits 12 13 +1
+ Misses 5 4 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. Just a couple of style-related things.
We also need a patch version bump :)
Co-authored-by: willtebbutt <[email protected]>
Since we haven't registered the package and we aren't making any releases yet, are the patch bumps useful? Also should we register once this is merged? |
Haha no patch bump, I think @willtebbutt just forgot it was not registered! We need to leave it at 0.1.0 or it will not be automatically merged |
🤦 @theogf is exactly correct - I keep forgetting that this package isn't registered yet... |
Me too 😆. Should we merge this and register now that we set up the tests? |
Sounds good to me. |
#18
Proposes a unified interface testing utilities similar to the ones added by @willtebbutt in JuliaGaussianProcesses/KernelFunctions.jl#159.