Skip to content

Relaxed transform to be used on Kernel #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Relaxed transform to be used on Kernel #125

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
860a4c7
Relaxed transform to be used on Kernel
theogf Jun 22, 2020
edce531
Update src/kernels/transformedkernel.jl
theogf Jun 22, 2020
0144641
Added more tests and removed transform(k, Nothing)
theogf Jun 22, 2020
855db6c
Removing broken tests
theogf Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/kernels/transformedkernel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,27 @@ _scale(t::ScaleTransform, metric, x, y) = evaluate(metric, t(x), t(y))

"""
```julia
transform(k::BaseKernel, t::Transform) (1)
transform(k::BaseKernel, ρ::Real) (2)
transform(k::BaseKernel, ρ::AbstractVector) (3)
transform(k::Kernel, t::Transform) (1)
transform(k::Kernel, ρ::Real) (2)
transform(k::Kernel, ρ::AbstractVector) (3)
```
(1) Create a TransformedKernel with transform `t` and kernel `k`
(2) Same as (1) with a `ScaleTransform` with scale `ρ`
(3) Same as (1) with an `ARDTransform` with scales `ρ`
"""
transform

transform(k::BaseKernel, t::Transform) = TransformedKernel(k, t)
transform(k::Kernel, t::Transform) = TransformedKernel(k, t)

transform(k::BaseKernel, ρ::Real) = TransformedKernel(k, ScaleTransform(ρ))
transform(k::TransformedKernel, t::Transform) =
TransformedKernel(k.kernel, t ∘ k.transform)

transform(k::Kernel, ρ::Real) = transform(k, ScaleTransform(ρ))

transform(k::Kernel, ρ::AbstractVector) = transform(k, ARDTransform(ρ))

transform(k::Kernel, ::Nothing) = k

transform(k::BaseKernel,ρ::AbstractVector) = TransformedKernel(k, ARDTransform(ρ))

kernel(κ) = κ.kernel

Expand Down