Skip to content

Conversation

@vovw
Copy link
Contributor

@vovw vovw commented Dec 23, 2024

makes it much easier to inspect the objects than the default printing which dumps all fields at once.
Screenshot 2024-12-23 at 4 24 36 PM

@vovw vovw requested a review from codetalker7 as a code owner December 23, 2024 11:12
@vovw
Copy link
Contributor Author

vovw commented Dec 25, 2024

@codetalker7 review ?

@codecov
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.96%. Comparing base (1480f52) to head (30f9c8f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/indexing.jl 0.00% 8 Missing ⚠️
src/searching.jl 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   56.93%   56.96%   +0.03%     
==========================================
  Files          16       16              
  Lines         699      739      +40     
==========================================
+ Hits          398      421      +23     
- Misses        301      318      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codetalker7
Copy link
Member

A minor thing about tests: can you also add some simple tests which just call the show methods? Some inspiration can be taken from other packages too (for instance see Flux: https://github.com/FluxML/Flux.jl/blob/7a3eafd5a71473df9e98b0992f9e84d5d6d9f978/test/layers/show.jl#L2).

@vovw
Copy link
Contributor Author

vovw commented Dec 25, 2024

i struggled with the tests a bit, would you mind taking a look?

@vovw vovw changed the title added pretty printing for config, indexer, searcher, residual codec added pretty printing for config, indexer, searcher Dec 27, 2024
@vovw
Copy link
Contributor Author

vovw commented Dec 28, 2024

resolved

@vovw vovw requested a review from codetalker7 December 28, 2024 10:26
@codetalker7 codetalker7 merged commit 4aa4a58 into JuliaGenAI:main Dec 28, 2024
5 of 6 checks passed
@codetalker7
Copy link
Member

Thanks @vovw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants