Remove ambiguity and implement getgeom, ngeom for Wrappers.Point#173
Open
asinghvi17 wants to merge 1 commit intomainfrom
Open
Remove ambiguity and implement getgeom, ngeom for Wrappers.Point#173asinghvi17 wants to merge 1 commit intomainfrom
getgeom, ngeom for Wrappers.Point#173asinghvi17 wants to merge 1 commit intomainfrom
Conversation
Member
|
Not sure We could also just return the point from getgeom and ngeom could be 1 Or error |
Member
Author
|
Error might be best? |
Member
|
Error is pretty safe as we can always change it later, but returning |
Member
|
Maybe Then |
Member
Author
|
Eh that sounds too recursive for my liking...let's just error |
Member
|
Where is this one at? |
asinghvi17
commented
Nov 8, 2025
Comment on lines
+321
to
+323
| ngeom(::PointTrait, geom::Point) = 0 | ||
| getgeom(::PointTrait, geom::Point) = nothing | ||
| getgeom(::PointTrait, geom::Point, i) = nothing |
Member
Author
There was a problem hiding this comment.
Suggested change
| ngeom(::PointTrait, geom::Point) = 0 | |
| getgeom(::PointTrait, geom::Point) = nothing | |
| getgeom(::PointTrait, geom::Point, i) = nothing | |
| ngeom(::PointTrait, geom::Point) = error("`GI.ngeom` on a Point is not allowed! To get the number of dimensions use `GI.ncoord` instead.") | |
| getgeom(::PointTrait, geom::Point) = error("`GI.getgeom` on a Point is not allowed! To get the number of dimensions use `GI.getcoord` instead, or `GI.x, GI.y, GI.z, GI.t`") | |
| getgeom(::PointTrait, geom::Point, i) = error("`GI.getgeom` on a Point is not allowed! To get the number of dimensions use `GI.getcoord` instead, or `GI.x, GI.y, GI.z, GI.t`") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mentioned on Slack, the output is probably a bit better than a method ambiguity error now.