Skip to content

Conversation

@asinghvi17
Copy link
Member

This was mentioned on Slack, the output is probably a bit better than a method ambiguity error now.

@rafaqz
Copy link
Member

rafaqz commented Oct 24, 2024

Not sure nothing is the best return value here.

We could also just return the point from getgeom and ngeom could be 1

Or error

@asinghvi17
Copy link
Member Author

Error might be best?

@rafaqz
Copy link
Member

rafaqz commented Oct 31, 2024

Error is pretty safe as we can always change it later, but returning nothing is permanent

@rafaqz
Copy link
Member

rafaqz commented Dec 13, 2024

Maybe GI.getgeom(point, 1) should return the point? a bit like how numbers work just returning themselves?

Then GI.ngeom(point) should return 1

@asinghvi17
Copy link
Member Author

Eh that sounds too recursive for my liking...let's just error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants