Skip to content

add convert methods #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add convert methods #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5264a54
add convert methods
rafaqz Dec 30, 2022
053964f
use geointerface_geomtype
rafaqz Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/geointerface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,48 +13,78 @@ GI.ncoord(::GI.AbstractTrait, ::AbstractGeometry{D,T}) where {D,T} = D
GI.coordinates(::GI.AbstractGeometryTrait, g::AbstractGeometry) = coordinates(g)
GI.coordinates(::GI.AbstractPointTrait, g::AbstractGeometry) = coordinates(g) # prevent ambiguity

geointerface_geomtype(::GI.PointTrait) = Point
geointerface_geomtype(::GI.LineStringTrait) = LineString
geointerface_geomtype(::GI.PolygonTrait) = Polygon
geointerface_geomtype(::GI.MultiLineStringTrait) = MultiLineString
geointerface_geomtype(::GI.MultiPolygonTrait) = MultiPolygon
geointerface_geomtype(::GI.GeometryCollectionTrait) = GeometryCollection

# we have to make use of the GI fallbacks that call geomtrait on the input
GI.getcoord(::GI.PointTrait, g::Point, i::Int) = g[i]
GI.convert(::Type{<:Point}, ::GI.PointTrait, geom) = Point(; coordinates=collect(GI.getcoord(geom)))

GI.ngeom(::GI.LineStringTrait, g::LineString) = length(g)
GI.getgeom(::GI.LineStringTrait, g::LineString{D,T}, i::Integer) where {D,T} = Point{D,T}(nothing, g[i])
GI.getpoint(::GI.LineStringTrait, g::LineString{D,T}, i::Int) where {D,T} = Point{D,T}(nothing, g[i])
# TODO what to return for length 0 and 1?
# TODO should this be an approximate equals for floating point?
GI.isclosed(::GI.LineStringTrait, g::LineString) = first(g) == last(g)
GI.convert(::Type{<:LineString}, ::GI.LineStringTrait, geom) =
LineString(; coordinates=GI.coordinates(geom))

GI.ngeom(::GI.PolygonTrait, g::Polygon) = length(g)
GI.getgeom(::GI.PolygonTrait, g::Polygon{D,T}, i::Integer) where {D,T} = LineString{D,T}(nothing, g[i])
GI.ncoord(::GI.PolygonTrait, g::Polygon) = length(first(first(g)))
GI.getexterior(::GI.PolygonTrait, g::Polygon{D,T}) where {D,T} = LineString{D,T}(nothing, first(g))
GI.nhole(::GI.PolygonTrait, g::Polygon) = length(g) - 1
GI.gethole(::GI.PolygonTrait, g::Polygon{D,T}, i::Int) where {D,T} = LineString{D,T}(nothing, g[i+1])
GI.convert(::Type{<:Polygon}, ::GI.PolygonTrait, geom) =
Polygon(; coordinates=GI.coordinates(geom))

GI.ngeom(::GI.MultiPointTrait, g::MultiPoint) = length(g)
GI.getgeom(::GI.MultiPointTrait, g::MultiPoint{D,T}, i::Int) where {D,T} = Point{D,T}(nothing, g[i])
GI.convert(::Type{<:MultiPoint}, ::GI.MultiPointTrait, geom) =
MultiPoint(; coordinates=GI.coordinates(geom))

GI.ngeom(::GI.MultiLineStringTrait, g::MultiLineString) = length(g)
GI.getgeom(::GI.MultiLineStringTrait, g::MultiLineString{D,T}, i::Int) where {D,T} =
LineString{D,T}(nothing, g[i])
GI.convert(::Type{<:MultiLineString}, ::GI.MultiLineStringTrait, geom) =
MultiLineString(; coordinates=GI.coordinates(geom))

GI.ngeom(::GI.MultiPolygonTrait, g::MultiPolygon) = length(g)
GI.getgeom(::GI.MultiPolygonTrait, g::MultiPolygon{D,T}, i::Int) where {D,T} = Polygon{D,T}(nothing, g[i])
GI.convert(::Type{<:MultiPolygon}, ::GI.MultiPolygonTrait, geom) =
MultiLineString(; coordinates=GI.coordinates(geom))

GI.ngeom(::GI.GeometryCollectionTrait, g::GeometryCollection) = length(g)
GI.getgeom(::GI.GeometryCollectionTrait, g::GeometryCollection, i::Int) = g[i]
GI.coordinates(::GI.GeometryCollectionTrait, g::GeometryCollection) = coordinates.(geometry(g))
function GI.convert(::Type{<:GeometryCollection}, ::GI.GeometryCollectionTrait, geom)
geometries = [GI.convert(Val{:GeoJSON}(), g) for g in GI.getgeoms(geom)]
GeometryCollection(; geometries)
end

# Feature
GI.isfeature(::Type{<:Feature}) = true
GI.trait(::Feature) = GI.FeatureTrait()
GI.geometry(f::Feature) = geometry(f)
GI.properties(f::Feature) = properties(f)
function GI.convert(::Type{<:Feature}, ::GI.FeatureTrait, feature)
Feature(;
geometry=GI.convert(GeoJSON, GI.geometry(feature)),
properties=GI.properties(feature),
)
end

# FeatureCollection
GI.isfeaturecollection(::Type{<:AbstractFeatureCollection}) = true
GI.trait(::AbstractFeatureCollection) = GI.FeatureCollectionTrait()
GI.getfeature(::GI.FeatureCollectionTrait, fc::AbstractFeatureCollection, i::Integer) = fc[i]
GI.nfeature(::GI.FeatureCollectionTrait, fc::AbstractFeatureCollection) = length(fc)
GI.convert(::Type{<:FeatureCollection}, ::GI.FeatureCollectionTrait, fc) =
FeatureCollection(GI.convert(Feature, GI.features(fc)))

# Any GeoJSON Object
GI.extent(::GI.FeatureTrait, x::GeoJSONT{2}) = _extent2(x)
Expand Down