Define crstrait if available #98
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All those CI errors look bad, but seem unrelated. Why did you go for static instead of just upping the compat? Most packages should be able to automatically get the latest GI? |
|
True, but that restricts people who are forced onto e.g. v1.2 of GeoInterface for unrelated reasons from getting any updated version of GeoJSON, so this seemed a bit more broadly compatible. I could just bump the version though. |
|
BTW, #99 fixes CI (but nightly fails on type inference for some other reason) |
|
bump @evetion - is this good to go from your end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.