Use ParallelTestRunner for tests #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Oct 18, 2025
| @safetestset "Manifold" begin include("core/manifold.jl") end | ||
| @safetestset "Applicators" begin include("core/applicators.jl") end | ||
| const init_code = quote | ||
| include(joinpath($(dirname(@__DIR__)), "test", "helpers.jl")) |
There was a problem hiding this comment.
You want to filter out this file: https://github.com/JuliaGeo/GeometryOps.jl/actions/runs/18616460074/job/53081619492?pr=348#step:7:695
|
As a general recommendation, you want to have files which roughly take the same time to run, and ideally each of them at least 10-15 seconds (doesn't have to be that strict, but to give you an indication). Having loads of files which take very few seconds, or even less, make scheduling much worse and the overhead of orchestrating the tests dwarfs running the tests themselves, in turn slowing everything down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/JuliaTesting/ParallelTestRunner.jl is the new hotness and also allows filtering on a specific file, very nice when developing.
But it needs some changes to how we write our tests, and TestHelpers probably needs to be a separate package in the structure.