add TileProviders.jl source code to this repo#47
Conversation
PkgTemplates version: 0.7.29
update URLs after mv to Julia Geo
Otherwise this infers to Any in geturl.
Use reduce as suggested here: https://discourse.julialang.org/t/replacing-multiple-strings-errors/13654/4
modify type anotation
reset to 0.1.3 because it was not tagged yet. Also set the compat for Dates to 1.0 to prepare for the detached standard libraries.
Set version to 0.1.3
* Bump codecov/codecov-action from 3 to 4 Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update .github/workflows/CI.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Bumps [julia-actions/setup-julia](https://github.com/julia-actions/setup-julia) from 1 to 2. - [Release notes](https://github.com/julia-actions/setup-julia/releases) - [Commits](julia-actions/setup-julia@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/setup-julia dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [julia-actions/cache](https://github.com/julia-actions/cache) from 1 to 2. - [Release notes](https://github.com/julia-actions/cache/releases) - [Commits](julia-actions/cache@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This one I don't get... TileProviders is fine as it is? It's already used directly by Leaflet.jl that needs nothing in MapTiles.jl. What do we gain from the move? |
|
Just to move everything in the map tile world into a monorepo. Should make life a lot easier if/when we start rendering vector tiles. |
To be clear this doesn't make TileProvider |
|
Woops sorry for the close/reopen
To be clear this doesn't change anything about TileProviders.jl other than the location of the code. I have no strong preference about doing this or not. Would be nice if the url https://juliageo.org/TileProviders.jl/dev/ keeps working. And don't squash on merge to keep the commits. |
|
Right, the idea here was to make this a Makie like monorepo. Then changes to interface are far easier to make if we need them (e.g, new interface functions for crs, boundingbox, preferred downloader, etc.) |
|
I'm really happy to have MapTilesBase.jl here in a subdir but I don't see the need to have TileProviders here until there is some real friction with where it currently is. I find monorepos lack discoverability, and are mostly justified when you need to do regular changes to many of the repos at once. But TileProviders.jl barely ever needs changes. (and the changes you are suggesting would still be one or two PRs much smaller than this one)
@visr what it changes is the context of development and discoverability for packages and custom usecases that just need those url paths. TileProviders.jl was meant to be a dead simple standalone package with a very clear and bounded use case - listing all the tile providers. |
|
Regardless if we merge this, I think we should move MapTiles to the /MapTiles subdir if we'll get MapTileBase. Just like Deltares/Wflow.jl#578. Makie has Makie at the root, and if you look under .julia/packages/Makie you'll see all subdir packages are there even though they don't do anything. If we merge this I'd probably also drop the .jl from TileProviders. |
|
That makes total sense - there is no need for the "main" package to contain the code of all the other packages in the repo. |
|
There's a valid point that TileProviders should be outside MapTiles. Maybe MapTiles.jl can pull TileProviders in and define the MapTilesInterface on TileProviders then, removing the need to monorepo-ize this. @visr that suggestion also makes sense - will move MapTiles.jl to a subdir in a future PR. Closing this for now since we aren't moving TileProviders source code here. |
|
@rafaqz yeah I'm aware, I'm not arguing for this change, was just making sure you understood the PR. Indeed if it had always been a well defined package I don't see a clear benefit to this PR (I do for MapTilesBase). Do note that Pkg handles url subdir installs pretty well. |
8 participants
No description provided.