Conversation
rafaqz
changed the title
Base.parent method for variable, and use it
Member
Author
|
Nightly failures are AWS problems, not this PR |
Member
Author
|
@Alexander-Barth can we get a merge and patch bump here too? |
Member
Author
|
Ok, as the same thing was merged in CDM I'm assuming this is ok... It's blocking Rasters updates currently and I would prefer to avoid special casing Zarr everywhere due to no parent method... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently its not possible to generically get the parent of the variable - we have to know the field is
var.zarrayand special case it in generic CommonDataModel.jl based code.This PR fixes that by adding a
Base.parentmethod, and using it everywhere. It shouldn't need a specific test as it is tested everywhere via the other methods.