Support for ASAGI files #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelligp
requested changes
Sep 25, 2024
| WriteVTK = "1" | ||
| WhereTheWaterFlows = "0.10" | ||
| WriteVTK = "1" | ||
| julia = "1.9" |
There was a problem hiding this comment.
Don't we need to specify newer versions on the project as well?
Suggested change
| julia = "1.9" | |
| julia = "1.9, 1.10" |
There was a problem hiding this comment.
no, 1.9 is the lower bound. We only need to put commas if it is a breaking release.
For packages that have version >=1.0, breaking releases are 1.0, 2.0 etc. For packages <1.0, a breaking release is 0.1, 0.2, 0.3, etc.
aelligp
approved these changes
Sep 25, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to read and write files in the ASAGI format used by codes such as SeisSol.
Note that we use the latest definition of the format as discussed here