Skip to content

Conversation

mitchellmcm27
Copy link

@mitchellmcm27 mitchellmcm27 commented Aug 27, 2025

I want to add the ability to set the initial APS, similar to how we can set the initial temperature and phases on the domain. Although pretty simple, this feature involves coordinated PRs in LaMEM, LaMEM.jl and GeophysicalModelGenerator.jl (see below). The changes are meant to be fully backwards compatible. I am leaving this as a draft as I want to get some feedback on the approach.

For more details, see the PR in the LaMEM repo (UniMainzGeo/LaMEM#41)

Summary of changes

LaMEM.jl (JuliaGeodynamics/LaMEM.jl#92)

  • adds APS as a property of Grid and passes it to CartData
  • adds ability to plot plast_strain as a cross-section (name matches Paraview field)
  • adds out_ptr_APS option to include APS on passive tracers (defaults to 0)

GeophysicalModelGenerator.jl (this PR)

  • writes APS from Grid as an additional property in the marker binary file (defaults to 0 if not given)
  • increments the file header to enable backwards compatibility

LaMEM (UniMainzGeo/LaMEM#41)

  • sets initial APS, if present, from marker binary file
  • interprets the file header (previously ignored) as a version number to maintain backwards compatibility
  • outputs APS as a field on markers
  • optionally outputs APS as a field on passive tracers (defaults to no APS output)
  • confirmed all tests pass locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant