CI on ALPS #242
CI on ALPS #242
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
cscs-ci run |
|
I guess in both single_particle_advection scripts this is missing: using ImplicitGlobalGrid
using MPI: MPI |
| # nodal vertices | ||
| xvi = xv, yv = let | ||
| dummy = zeros(n, n) | ||
| xv = TA([x_g(i, dx, dummy) for i in axes(dummy, 1)]) |
There was a problem hiding this comment.
Getting now an error here about:
ERROR: MethodError: no method matching TA(::Vector{Float64})
The function `TA` exists, but no method is defined for this combination of argument types.
Closest candidates are:
TA()
@ JustPIC ~/Documents/code/github_juliagd/JustPIC.jl/src/JustPIC.jl:17
TA(::Type{JustPIC.CPUBackend})
@ JustPIC ~/Documents/code/github_juliagd/JustPIC.jl/src/JustPIC.jl:18
| grid_vx = xv, expand_range(yc, dy) | ||
| grid_vy = expand_range(xc, dx), yv | ||
|
|
||
| particles = init_particles( |
There was a problem hiding this comment.
This is now breaking
| version: | ||
| - "1.10" | ||
| - "1.11" | ||
| - "1.12-nightly" |
There was a problem hiding this comment.
Wouldnt it make more sense to have 'pre' here for the pre-releases?
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
|
Having fixed the obvious in AMDGPU ext, we are now getting an error about method redefinition in https://buildkite.com/julialang/justpic-dot-jl/builds/1382#0198a99d-6278-4de5-82f2-33af48d60276/243-389 when running the AMDGPU tests in Buildkite (@albert-de-montserrat) EDIT: Note that if this is not an obvious fix, maybe we can address it in a separate PR. |
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
No description provided.