Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
===========================================
+ Coverage 95.86% 100.00% +4.13%
===========================================
Files 17 18 +1
Lines 290 284 -6
===========================================
+ Hits 278 284 +6
+ Misses 12 0 -12 ☔ View full report in Codecov by Sentry. |
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Collaborator
Author
Ah, good catch. I forgot to remove the |
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
_ParametricGeometry <: Meshes.Geometrytype to serve as a simple wrapper for custom parametric functions_parametric(geometry, ts...).BezierCurveandTetrahedrongeometries, closing Integral onTetrahedronnot fully supported #40. This achieved an 80x performance improvement for integrals over aBezierCurve.jacobian(::BezierCurve, ts, ::Analytical)method - performance was inferior to the genericFiniteDifferencemethod.extendedtag fromTetrahedrontests now that they return in reasonable CI timespans.Base.zerosto_zeros, providingHAdaptiveCubatureintegrals with an up to 20% performance improvement.Discussion
This is a follow-up to #131, where the scope of changes had become over-extended. Some of those changes were implemented separately in other PR’s.
I’ve chosen not to also tackle other specialization geometries yet, since those seemed to suffer performance penalties. Those implementations are left for future work.