Add support for integrating over PolyArea and Domain types#182
Add support for integrating over PolyArea and Domain types#182mikeingold merged 40 commits intomainfrom
PolyArea and Domain types#182Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
|
Interesting. The remaining errors with the |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Still debugging. One of the remaining issues ( Edit: got it. There was a holdover in the default rule selection for the |
|
I've run some tests locally to figure out why the
|
|
Based on a little more debugging, even in the longer |
|
I had a vague suspicion that turned out to be true. The really extreme CI times were nearly 100% compilation time. The output of |
|
@juliohm Should |
|
It is an internal type for dispatch purposes. Not something intended for
end users.
Em sáb., 19 de jul. de 2025, 14:12, Michael Ingold ***@***.***>
escreveu:
… *mikeingold* left a comment (JuliaGeometry/MeshIntegrals.jl#182)
<#182 (comment)>
@juliohm <https://github.com/juliohm> Should Meshes.GeometryOrDomain be
exported? This PR currently triggers a CI fail (ExplicitImports.jl) over
importing it as a non-public/exported reference. I can always just define
it locally if it wasn't intended for stable external use.
—
Reply to this email directly, view it on GitHub
<#182 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3IDUQQEG23ZVAWASFD3JJ37HAVCNFSM6AAAAAB76YG6B6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJSGQ3DCNJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 19 +1
Lines 181 190 +9
=========================================
+ Hits 181 190 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
<:Meshes.Domain typesPolyArea and Domain types
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JoshuaLampert
left a comment
There was a problem hiding this comment.
Really nice! I only have some minor comments.
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
|
I accepted the suggestions but had to reformat the |
Changes
integralmethods forMeshes.PolyAreaand subtypes ofMeshes.Domainwith explicit tests forCartesianGridPolyAreaRegularGridSimpleMeshlineintegral) to also acceptDomains.Closes:
SimpleMeshnot yet implemented #27PolyAreanot yet implemented #169