Skip to content

Add Base.show for integration rules #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeingold merged 3 commits into from
Jul 24, 2025
Merged

Add Base.show for integration rules #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70126ca
add Base.show for integration rules
JoshuaLampert Jul 24, 2025
952dfa8
add _kwargs_to_string function
JoshuaLampert Jul 24, 2025
d5db351
Merge branch 'main' into show-integration-rules
JoshuaLampert Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/integration_rules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
# Integration Rules
################################################################################

function _kwargs_to_string(kwargs)
return join([string(k) * " = " * string(v) for (k, v) in pairs(kwargs)], ", ")
end

abstract type IntegrationRule end

"""
Expand All @@ -18,6 +22,10 @@ struct GaussKronrod <: IntegrationRule
GaussKronrod(; kwargs...) = new(kwargs)
end

function Base.show(io::IO, rule::GaussKronrod)
print(io, "GaussKronrod(; ", _kwargs_to_string(rule.kwargs), ")")
end

"""
GaussLegendre(n)

Expand All @@ -39,6 +47,10 @@ struct GaussLegendre <: IntegrationRule
GaussLegendre(n::Int64) = new(n, FastGaussQuadrature.gausslegendre(n)...)
end

function Base.show(io::IO, rule::GaussLegendre)
print(io, "GaussLegendre(", rule.n, ")")
end

"""
HAdaptiveCubature(kwargs...)

Expand All @@ -50,3 +62,7 @@ struct HAdaptiveCubature <: IntegrationRule
kwargs::Base.Pairs
HAdaptiveCubature(; kwargs...) = new(kwargs)
end

function Base.show(io::IO, rule::HAdaptiveCubature)
print(io, "HAdaptiveCubature(; ", _kwargs_to_string(rule.kwargs), ")")
end
8 changes: 8 additions & 0 deletions test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@
import Enzyme
end

@testitem "Integration Rules" begin
@test sprint(show, GaussKronrod(; atol = 1e-12, rtol = 1e-10)) ==
"GaussKronrod(; atol = 1.0e-12, rtol = 1.0e-10)"

@test sprint(show, GaussLegendre(5)) == "GaussLegendre(5)"
@test sprint(show, HAdaptiveCubature()) == "HAdaptiveCubature(; )"
end

@testitem "Utilities" setup=[Utils] begin
# _KVector
v = Meshes.Vec(3, 4)
Expand Down
Loading