Refactor withcrs (#1023)

* Refactor 'withcrs'

* Apply suggestions from code review

Co-authored-by: Júlio Hoffimann <[email protected]>

---------

Co-authored-by: Júlio Hoffimann <[email protected]>

Author: eliascarv

src/transforms/shadow.jl

@@ -83,7 +83,11 @@ _sort(dims) = sort(SVector(dims))
 
 _shadow(v::Vec, dims) = v[dims]
 
-_shadow(p::Point, dims) = withcrs(p, to(p)[dims])
+function _shadow(p::Point, dims)
+  v = _shadow(to(p), dims)
+  c = Cartesian{datum(crs(p))}(v...)
+  Point(c)
+end
 
 function _shadow(g::CartesianGrid, dims)
   sz = size(g)[dims]

src/utils/crs.jl

@@ -9,9 +9,9 @@ Point at the end of the vector `v` with the same CRS of `g`.
 """
 function withcrs(g::GeometryOrDomain, v::StaticVector)
   C = crs(g)
-  cart = Cartesian{datum(C)}(Tuple(v))
-  ctor = CoordRefSystems.constructor(C)
-  Point(convert(ctor, cart))
+  D = datum(C)
+  c = convert(C, Cartesian{D}(v...))
+  Point(c)
 end
 
 """

test/intersections.jl

@@ -831,7 +831,7 @@
     b1 = Box((T(0) * u"cm", T(0) * u"cm"), (T(100) * u"cm", T(100) * u"cm"))
     b2 = Box((T(500) * u"mm", T(500) * u"mm"), (T(2000) * u"mm", T(2000) * u"mm"))
     @test intersection(b1, b2) |> type == Overlapping
-    @test unit(Meshes.lentype(b1 ∩ b2)) == u"m"
+    @test unit(Meshes.lentype(b1 ∩ b2)) == u"cm"
     @test b1 ∩ b2 == Box(cart(0.5, 0.5), cart(1, 1))
 
     # type stability tests