Bottom top fixes

[juliohm]

Miscellaneous fixes before #1327

[github-actions]

Benchmark Results (Julia vlts)

Time benchmarks

	master	687a2b0...	master / 687a2b0...
clipping/SutherlandHodgman	3.73 ± 0.2 μs	3.71 ± 1.9 μs	1.01 ± 0.51
discretization/simplexify	0.675 ± 0.12 ms	0.682 ± 0.1 ms	0.99 ± 0.23
intersection/ray-triangle	0.05 ± 0.001 μs	0.05 ± 0.001 μs	1 ± 0.028
sideof/ring/large	6.53 ± 0.01 μs	6.53 ± 0.01 μs	1 ± 0.0022
sideof/ring/small	0.051 ± 0.01 μs	0.05 ± 0.001 μs	1.02 ± 0.2
topology/half-edge	2.74 ± 0.047 ms	2.73 ± 0.056 ms	1 ± 0.027
winding/mesh	16.5 ± 0.33 ms	16 ± 0.34 ms	1.03 ± 0.03
time_to_load	1.2 ± 0.005 s	1.2 ± 0.021 s	0.998 ± 0.018

Memory benchmarks

	master	687a2b0...	master / 687a2b0...
clipping/SutherlandHodgman	0.053 k allocs: 4.97 kB	0.053 k allocs: 4.97 kB	1
discretization/simplexify	18.1 k allocs: 1.92 MB	18.1 k allocs: 1.92 MB	1
intersection/ray-triangle	0 allocs: 0 B	0 allocs: 0 B
sideof/ring/large	0 allocs: 0 B	0 allocs: 0 B
sideof/ring/small	0 allocs: 0 B	0 allocs: 0 B
topology/half-edge	18.1 k allocs: 2.92 MB	18.1 k allocs: 2.92 MB	1
winding/mesh	23.2 k allocs: 3.08 MB	23.2 k allocs: 3.08 MB	1
time_to_load	0.153 k allocs: 14.5 kB	0.153 k allocs: 14.5 kB	1

[github-actions]

Benchmark Results (Julia v1)

Time benchmarks

	master	687a2b0...	master / 687a2b0...
clipping/SutherlandHodgman	2.66 ± 0.21 μs	2.68 ± 0.25 μs	0.993 ± 0.12
discretization/simplexify	0.379 ± 0.018 ms	0.381 ± 0.018 ms	0.996 ± 0.065
intersection/ray-triangle	0.05 ± 0.01 μs	0.05 ± 0.001 μs	1 ± 0.2
sideof/ring/large	6.7 ± 0.019 μs	6.85 ± 0.01 μs	0.978 ± 0.0031
sideof/ring/small	0.06 ± 0 μs	0.06 ± 0 μs	1 ± 0
topology/half-edge	2.72 ± 0.21 ms	2.73 ± 0.22 ms	0.999 ± 0.11
winding/mesh	15.3 ± 0.22 ms	15.3 ± 0.11 ms	0.998 ± 0.016
time_to_load	1 ± 0.0074 s	1 ± 0.0051 s	0.997 ± 0.0089

Memory benchmarks

	master	687a2b0...	master / 687a2b0...
clipping/SutherlandHodgman	0.064 k allocs: 5.55 kB	0.064 k allocs: 5.55 kB	1
discretization/simplexify	0.0362 M allocs: 1.93 MB	0.0362 M allocs: 1.93 MB	1
intersection/ray-triangle	0 allocs: 0 B	0 allocs: 0 B
sideof/ring/large	0 allocs: 0 B	0 allocs: 0 B
sideof/ring/small	0 allocs: 0 B	0 allocs: 0 B
topology/half-edge	25.9 k allocs: 3.17 MB	25.9 k allocs: 3.17 MB	1
winding/mesh	0.0413 M allocs: 3.08 MB	0.0413 M allocs: 3.08 MB	1
time_to_load	0.145 k allocs: 11 kB	0.145 k allocs: 11 kB	1

[JoshuaLampert]

Thanks! Would you consider this breaking or a bug fix? I would be fine with both.

[juliohm]

I think it is breaking, but we have other breaking changes planned before the next release. So I am just going to merge this for now and continue the work we are doing with integrals.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.54%. Comparing base (203ab19) to head (687a2b0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
+ Coverage   85.50%   85.54%   +0.03%     
==========================================
  Files         199      199              
  Lines        6376     6384       +8     
==========================================
+ Hits         5452     5461       +9     
+ Misses        924      923       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.