Bugfixes and API changes for updated Electron#309
Draft
mosullivan93 wants to merge 1 commit intoJuliaGizmos:masterfrom
Draft
Bugfixes and API changes for updated Electron#309mosullivan93 wants to merge 1 commit intoJuliaGizmos:masterfrom
mosullivan93 wants to merge 1 commit intoJuliaGizmos:masterfrom
Conversation
The API for performing dialog operations has changed significantly since the last working version of Electron. This patch provides the following improvements: 1) A more robust override mechanism for BrowserWindow defaults. 2) Compatibility with or without contextIsolation for asynchronous dialog operations. 3) A user friendly mechanism for adding renderer preload scripts to extend the namespace of isolated windows. 4) Miscellaneous bugfixes: Julia icon path, keys in window_defaults dictionary, syntax update for invoking debugger.
Contributor
Author
|
Converting to draft. I would like to do a few more tests on the new features and add documentation for them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API for performing dialog operations has changed significantly since the last version of Electron used in the package. Specifically, this PR makes the necessary backend changes to remedy issues with the dialog widgets seen with the updated Electron from Blink >=v0.12.6. This PR may require additional thought about an update to
Project.tomlto ensure that the mutual dependencies on the patches will be satisfied by users of both packages.This patch provides the following improvements:
BrowserWindowdefaults.contextIsolationfor asynchronous dialog operations.window_defaultsdictionary, syntax update for invoking debugger.