Skip to content

Add a general validity check before setting a value, abort if not fulfilled #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hhaensel wants to merge 2 commits into from
Closed

Add a general validity check before setting a value, abort if not fulfilled #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f54f124
add a more general validity check for updates
Jul 5, 2022
00cf4be
add a more general validity check
Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Observables.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ mutable struct Observable{T} <: AbstractObservable{T}

listeners::Vector{Pair{Int, Any}}
inputs::Vector{Any} # for map!ed Observables
ignore_equal_values::Bool
isinvalid::Union{Nothing, Function}
val::T

function Observable{T}(; ignore_equal_values::Bool=false) where {T}
return new{T}(Pair{Int, Any}[], [], ignore_equal_values)
return new{T}(Pair{Int, Any}[], [], ignore_equal_values ? isequal : nothing)
end
function Observable{T}(@nospecialize(val); ignore_equal_values::Bool=false) where {T}
return new{T}(Pair{Int, Any}[], [], ignore_equal_values, val)
return new{T}(Pair{Int, Any}[], [], ignore_equal_values ? isequal : nothing, val)
end
end

Expand Down Expand Up @@ -79,8 +79,8 @@ listeners(observable::Observable) = observable.listeners
Updates the value of an `Observable` to `val` and call its listeners.
"""
function Base.setindex!(@nospecialize(observable::Observable), @nospecialize(val))
if observable.ignore_equal_values
isequal(observable.val, val) && return
if !isnothing(observable.isinvalid)
observable.isinvalid(observable.val, val) && return
end
observable.val = val
return notify(observable)
Expand Down