Skip to content

Conversation

@pfitzseb
Copy link

@pfitzseb pfitzseb commented May 2, 2017

and fix test errors on Windows and 0.6.

Fixes #117.

pfitzseb added 2 commits May 2, 2017 16:49
and fix test errors on Windows and 0.6
@pfitzseb
Copy link
Author

pfitzseb commented May 2, 2017

Just noticed that this includes the fix from #136 -- not sure how we should handle that.

@pfitzseb
Copy link
Author

pfitzseb commented May 2, 2017

OSX nightly test error is unrelated.

@aviks
Copy link
Collaborator

aviks commented Feb 5, 2020

What was the motivation for changing Text to TkText? Much of the incidental changes in this PR is stale, but I'm trying to understand if the core change is still required.

@pfitzseb
Copy link
Author

pfitzseb commented Feb 5, 2020

The fact that both Base and Tk export Text leads to fun stuff like

julia> Text("asd")
asd

julia> using Tk

julia> Text("asd")
ERROR: MethodError: no method matching Tk.TkWidget(::String, ::String)

julia> Base.Text("asd")
ERROR: MethodError: no method matching Tk.TkWidget(::String, ::String)

julia> Base.Docs.Text("asd")
ERROR: MethodError: no method matching Tk.TkWidget(::String, ::String)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tk overwrites Base.Text

2 participants