[GNNFlux] Translate Traffic prediction Pluto notebook to Literate
#572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # ## Dataset: METR-LA | ||
|
|
||
| # We use the `METR-LA` dataset from the paper [Diffusion Convolutional Recurrent Neural Network: Data-driven Traffic Forecasting](https://arxiv.org/pdf/1707.01926.pdf), which contains traffic data from loop detectors in the highway of Los Angeles County. The dataset contains traffic speed data from March 1, 2012 to June 30, 2012. The data is collected every 5 minutes, resulting in 12 observations per hour, from 207 sensors. Each sensor is a node in the graph, and the edges represent the distances between the sensors. |
There was a problem hiding this comment.
What does it mean the edges represent the distances between the sensors? should be clarified
There was a problem hiding this comment.
better something like: the edge weights are the distances between the sensor locations?
Comment on lines
66
to
67
| train_loader = zip(features[1:200], targets[1:200]); | ||
| test_loader = zip(features[2001:2288], targets[2001:2288]); |
There was a problem hiding this comment.
motivate this choice of ranges
GraphNeuralNetworks/docs/src_tutorials/introductory_tutorials/traffic_prediction.jl
Show resolved
Hide resolved
| model = GNNChain(TGCN(2 => 100; add_self_loops = false), Dense(100, 1)) | ||
|
|
||
| #  | ||
|
|
There was a problem hiding this comment.
here it would be useful to show the output of the model and how it is interpreted as a prediction
aurorarossi
added a commit
that referenced
this pull request
Jan 2, 2025
* Fix temporal graph classification literate * [GNNFlux] Translate `Traffic prediction` Pluto notebook to Literate (#572) * Add traffic prediction * Fixes * Fix temporal graph classification literate * Back to Vector * Fixes * Add info about 250 graphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#545