Skip to content

Provide CUDA support for the binarize() operation on sparse matrices #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 21, 2025
Merged

Provide CUDA support for the binarize() operation on sparse matrices #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df734e1
Add binarize function for CuSparseMatrixCSC and update its usage
dferre97 Jun 14, 2025
4c0c38e
Refactor CUDA binarize function to use Bool as the CPU version
dferre97 Jun 15, 2025
ccd9058
Revert unrelated changes, make coherent PR on binarize() and nothing …
dferre97 Jun 16, 2025
7e6694d
Removed debug prints
dferre97 Jun 17, 2025
adc6cf9
Unify binarize function signature
dferre97 Jun 19, 2025
bef10aa
Remove debug print statement from binarize function
dferre97 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions GNNGraphs/ext/GNNGraphsCUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ using CUDA
using Random, Statistics, LinearAlgebra
using GNNGraphs
using GNNGraphs: COO_T, ADJMAT_T, SPARSE_T
using SparseArrays

const CUMAT_T = Union{CUDA.AnyCuMatrix, CUDA.CUSPARSE.CuSparseMatrix}

Expand All @@ -20,6 +21,11 @@ GNNGraphs.dense_zeros_like(a::CUMAT_T, T::Type, sz = size(a)) = CUDA.zeros(T, sz

GNNGraphs.iscuarray(x::AnyCuArray) = true

function GNNGraphs.binarize(Mat::CUSPARSE.CuSparseMatrixCSC, T::DataType = Bool)
bin_vals = fill!(similar(nonzeros(Mat)), one(T))
return CUSPARSE.CuSparseMatrixCSC(Mat.colPtr, rowvals(Mat), bin_vals, size(Mat))
end


function sort_edge_index(u::AnyCuArray, v::AnyCuArray)
dev = get_device(u)
Expand Down
4 changes: 2 additions & 2 deletions GNNGraphs/src/query.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ function Graphs.adjacency_matrix(g::GNNGraph{<:ADJMAT_T}, T::DataType = eltype(g
@assert dir ∈ [:in, :out]
A = g.graph
if !weighted
A = binarize(A)
A = binarize(A, T)
end
A = T != eltype(A) ? T.(A) : A
return dir == :out ? A : A'
Expand Down Expand Up @@ -377,7 +377,7 @@ end

function _degree(A::AbstractMatrix, T::Type, dir::Symbol, edge_weight::Bool, num_nodes::Int)
if edge_weight === false
A = binarize(A)
A = binarize(A, T)
end
A = eltype(A) != T ? T.(A) : A
return dir == :out ? vec(sum(A, dims = 2)) :
Expand Down
2 changes: 1 addition & 1 deletion GNNGraphs/src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ function _rand_edges(rng, (n1, n2), m)
return s, t, val
end

binarize(x) = map(>(0), x)
binarize(x, T::DataType = Bool) = ifelse.(x .> 0, one(T), zero(T))

CRC.@non_differentiable binarize(x...)
CRC.@non_differentiable edge_encoding(x...)
Expand Down
Loading