Move JLD2.jl dependency to a package extension #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter will lead to invalidations when JLD2 is loaded
ext/MetaGraphsJLD2Ext.jl
Outdated
Comment on lines
17
to
58
| # escaping unescaped quotation marks | ||
| # i.e. replacing `"`` with `\"` while leaving `\"` as is | ||
| escape_quotes(s::AbstractString) = replace(s, r"([^\\])\"" => s"\1\\\\\"") | ||
|
|
||
| # According to the DOT language specification https://graphviz.org/doc/info/lang.html | ||
| # we can quote everyhthing that's not an XML/HTML literal | ||
| function quote_prop(p::AbstractString) | ||
| if occursin(r"<+.*>+$", p) | ||
| # The label is an HTML string, no additional quotes here. | ||
| return p | ||
| else | ||
| return "\"" * escape_quotes(p) * "\"" | ||
| end | ||
| end | ||
| # if the property value is _not_ a string it cannot be XML/HTML literal, so just put it in quotes | ||
| quote_prop(p::Any) = "\"" * escape_quotes(string(p)) * "\"" | ||
| # NOTE: down there I only quote property _values_. DOT allows quoting property _names_ too | ||
| # I don't do that as long as names are Symbols and can't have spaces and commas and stuff. | ||
| # That will break if someone uses a DOT keyword as a property name, as they must be quoted. | ||
|
|
||
| function MetaGraphs.savedot(io::IO, g::AbstractMetaGraph) | ||
| if is_directed(g) | ||
| write(io, "digraph G {\n") | ||
| dash = "->" | ||
| else | ||
| write(io, "graph G {\n") | ||
| dash = "--" | ||
| end | ||
|
|
||
| for p in props(g) | ||
| write(io, "$(p[1])=$(quote_prop(p[2]));\n") | ||
| end | ||
|
|
||
| for v in vertices(g) | ||
| write(io, "$v") | ||
| if length(props(g, v)) > 0 | ||
| write(io, " [ ") | ||
|
|
||
| for p in props(g, v) | ||
| write(io, "$(p[1])=$(quote_prop(p[2])), ") | ||
| end | ||
|
|
There was a problem hiding this comment.
Are these functions in any way connected to the JLD2 backend?
I think these should stay in the main package.
Member
Author
There was a problem hiding this comment.
good point, they don't look like they are
Member
Author
There was a problem hiding this comment.
I moved the dot format stuff back to the package. Note that the savedot function is neither tested, documented, or exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.