-
Notifications
You must be signed in to change notification settings - Fork 23
Bump JLD2 compat #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump JLD2 compat #91
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 6 6
Lines 325 325
=======================================
Hits 293 293
Misses 32 32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the tests are still running with outdated versions of everything:
Testing MetaGraphsNext
┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ Pkg.Operations /opt/hostedtoolcache/julia/1.11.6/x64/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1924
Status `/tmp/jl_USoAJz/Project.toml`
[4c88cf16] Aqua v0.8.14
[6e4b80f9] BenchmarkTools v1.6.0
[e30172f5] Documenter v1.14.1
[86223c79] Graphs v1.13.1
⌅ [033835bb] JLD2 v0.4.54
⌅ [98e50ef6] JuliaFormatter v1.0.62
⌅ [626554b9] MetaGraphs v0.7.2
[fa8bd995] MetaGraphsNext v0.7.3 `~/work/MetaGraphsNext.jl/MetaGraphsNext.jl`
[699a6c99] SimpleTraits v0.9.5
[b77e0a4c] InteractiveUtils v1.11.0
[8dfed614] Test v1.11.0
Can you bump the rest of the deps and see if that solves it?
Could you maybe re-enable CompatHelper then? |
CompatHelper is now re-enabled. |
@simsurace , if you are having MetaGraphsNext as a dependency, are you interested in signing up on the maintenance team. The Graphs team conventionally follows the same contributor rules like SciML -- as long as there is a review of a PR, it can be merged but if the PR is from someone with no merge rights it needs to be reviewed by someone with merge rights. We are pretty short on maintenance volunteers right now, so help is appreciated. |
Sure, I'm happy to help out! |
Thanks! An invitation is now send! You should have merge rights for this repo now. As long as tests pass, feel free to merge this compat fixes -- they look good to me. |
(presumably that will involve the other compathelper fixes) |
MetaGraphs.jl also needs a bump, so I'll fix that one first. |
Tests now pick up JLD2 v0.6 |
thanks! |
No description provided.