Skip to content

Conversation

simsurace
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (e3dd6dc) to head (f862f95).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files           6        6           
  Lines         325      325           
=======================================
  Hits          293      293           
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the tests are still running with outdated versions of everything:

      Testing MetaGraphsNext
┌ Warning: Could not use exact versions of packages in manifest, re-resolving
└ @ Pkg.Operations /opt/hostedtoolcache/julia/1.11.6/x64/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1924
      Status `/tmp/jl_USoAJz/Project.toml`
  [4c88cf16] Aqua v0.8.14
  [6e4b80f9] BenchmarkTools v1.6.0
  [e30172f5] Documenter v1.14.1
  [86223c79] Graphs v1.13.1
⌅ [033835bb] JLD2 v0.4.54
⌅ [98e50ef6] JuliaFormatter v1.0.62
⌅ [626554b9] MetaGraphs v0.7.2
  [fa8bd995] MetaGraphsNext v0.7.3 `~/work/MetaGraphsNext.jl/MetaGraphsNext.jl`
  [699a6c99] SimpleTraits v0.9.5
  [b77e0a4c] InteractiveUtils v1.11.0
  [8dfed614] Test v1.11.0

Can you bump the rest of the deps and see if that solves it?

@simsurace
Copy link
Member Author

Could you maybe re-enable CompatHelper then?

@Krastanov
Copy link
Member

CompatHelper is now re-enabled.

@Krastanov
Copy link
Member

@simsurace , if you are having MetaGraphsNext as a dependency, are you interested in signing up on the maintenance team. The Graphs team conventionally follows the same contributor rules like SciML -- as long as there is a review of a PR, it can be merged but if the PR is from someone with no merge rights it needs to be reviewed by someone with merge rights. We are pretty short on maintenance volunteers right now, so help is appreciated.

@simsurace
Copy link
Member Author

Sure, I'm happy to help out!

@Krastanov
Copy link
Member

Thanks! An invitation is now send! You should have merge rights for this repo now. As long as tests pass, feel free to merge this compat fixes -- they look good to me.

@Krastanov
Copy link
Member

(presumably that will involve the other compathelper fixes)

@simsurace
Copy link
Member Author

MetaGraphs.jl also needs a bump, so I'll fix that one first.

@simsurace simsurace requested a review from gdalle August 27, 2025 14:36
@simsurace
Copy link
Member Author

simsurace commented Aug 27, 2025

Tests now pick up JLD2 v0.6

@Krastanov Krastanov merged commit 46bef09 into JuliaGraphs:master Aug 28, 2025
7 checks passed
@Krastanov
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants