-
Notifications
You must be signed in to change notification settings - Fork 13
Make algorithm argument mandatory in jet_reconstruct
#161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI fails to setup the Julia actions I think it's something with GitHub as I can download the links they can't without issues OK looks like it was temporary outage |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 75.23% 74.96% -0.28%
==========================================
Files 20 20
Lines 1284 1270 -14
==========================================
- Hits 966 952 -14
Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this @m-fila! It looks very complete to me, just a few minor issues to clean up in the README.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is GTG now!
This is a breaking change
The
algorithmkeyword argument will be mandatory injet_reconstruct, which effectively removes callingjet_reconstructwithpower. The power will be still a keyword argument:This allows to simplify the logic a bit and also will be easier to support in C-bindings #88
A few internal functions are removed. The internal
algorithm2powerdictionary now maps both pp and ee algorithms to their power, dictionary going in opposite direction is removedInternal algorithms (
_plain_jet_reconstructetc) assume thatalgorithmandpgiven to them is consistent and won't check it or resolve againCloses #129