Fix Float Point Bug #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flavour Tagging features. (src/, examples/flavour-tagging)
…struction still have EEjet
A few improvements to .gitignore Make dependency on JetReconstruction for v1.0 (currently in development) Change back to EEJet (no alias needed) Update calling signatures
Changed EEJet type alias to EEJet from JetReconstruction Using Pkg in the example to compile 1.0.0-DEV version of JetReconstruction
More sincos() and inline simd to optimize.
In some special case, there would be small negative value like -3e-10. We fix this by using atan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix found float point bug where small negative value appear under square root in dz and phi0. (e.g. sqrt(-3e-9))