Skip to content

Warn about Pulseq 1.5.0 support gap#635

Merged
cncastillo merged 18 commits intomasterfrom
pulseq-150-warn
Oct 14, 2025
Merged

Warn about Pulseq 1.5.0 support gap#635
cncastillo merged 18 commits intomasterfrom
pulseq-150-warn

Conversation

@cncastillo
Copy link
Member

@cncastillo cncastillo commented Oct 14, 2025

Summary

  • warn when loading Pulseq files at or above v1.5.0, pointing to PR Read Pulseq 1.5.1 #614 for progress
  • store and compare Pulseq versions using Julia’s VersionNumber instead of encoded integers
  • bump KomaMRIFiles to v0.9.5 for the warning and version-handling update

Closes #555
Closes #174

Disclaimer: This PR is an experiment of using coding agents to solve trivial issues. Everything here was written by Codex CLI.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.09%. Comparing base (5169ddb) to head (70c1b9f).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
KomaMRIFiles/src/Sequence/Pulseq.jl 91.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          57       57           
  Lines        3230     3230           
=======================================
  Hits         2910     2910           
  Misses        320      320           
Flag Coverage Δ
base 88.94% <ø> (ø)
core 89.73% <ø> (ø)
files 94.05% <91.30%> (ø)
komamri 88.21% <ø> (ø)
plots 90.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
KomaMRIFiles/src/Sequence/Pulseq.jl 93.84% <91.30%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cncastillo cncastillo merged commit dac47ed into master Oct 14, 2025
18 checks passed
@cncastillo cncastillo deleted the pulseq-150-warn branch October 14, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a warning when higher version are not handled (like Pulseq 1.5.0) Change version_combined varibable to type VersionNumber in Pulseq IO

1 participant