Fix error handling when unsupported (and required) extensions are read#729
Open
pvillacorta wants to merge 1 commit intomasterfrom
Open
Fix error handling when unsupported (and required) extensions are read#729pvillacorta wants to merge 1 commit intomasterfrom
pvillacorta wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
==========================================
- Coverage 91.03% 88.86% -2.18%
==========================================
Files 61 61
Lines 3357 3358 +1
==========================================
- Hits 3056 2984 -72
- Misses 301 374 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
We need to add a sequence such as that in #728 for testing (how can we test when an error is the expected output?) |
Member
|
why is this change needed? I dont think the error comes from not identifying the dictionary key "RequiredExtensions" unless in the code it means something else. I can fully remove the error by defining rotations. I will upload a PR, so you can see what i mean. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.