Draft
Conversation
Comment on lines
+41
to
+43
| [sources] | ||
| OrdinaryDiffEqOperatorSplitting = {url = "https://github.com/SciML/OrdinaryDiffEqOperatorSplitting.jl.git", rev = "main"} | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| [sources] | |
| OrdinaryDiffEqOperatorSplitting = {url = "https://github.com/SciML/OrdinaryDiffEqOperatorSplitting.jl.git", rev = "main"} |
| OrdinaryDiffEqCore = "1" | ||
| OrdinaryDiffEqLowOrderRK = "1.2.0" | ||
| OrdinaryDiffEqOperatorSplitting = "0.1" | ||
| OrdinaryDiffEqOperatorSplitting = "0.2" |
Collaborator
There was a problem hiding this comment.
Suggested change
| OrdinaryDiffEqOperatorSplitting = "0.2" | |
| OrdinaryDiffEqOperatorSplitting = "0.2.1" |
Comment on lines
+18
to
+19
| [sources] | ||
| OrdinaryDiffEqOperatorSplitting = {url = "https://github.com/SciML/OrdinaryDiffEqOperatorSplitting.jl.git", rev = "main"} |
Collaborator
There was a problem hiding this comment.
Suggested change
| [sources] | |
| OrdinaryDiffEqOperatorSplitting = {url = "https://github.com/SciML/OrdinaryDiffEqOperatorSplitting.jl.git", rev = "main"} |
| return semidiscrete_problem | ||
| end | ||
|
|
||
| function Thunderbolt.semidiscretize(coupled_model::ElectroMechanicalCoupledModel, discretizations::Tuple, meshes::Tuple{<:Thunderbolt.AbstractGrid, <:Thunderbolt.AbstractGrid}) |
Collaborator
There was a problem hiding this comment.
Can we add some annotation that this semidiscretizes splits the model? E.g. PhyiscalSplit{Elec....}?
Comment on lines
+12
to
+13
| ep_index::Int | ||
| mech_index::Int |
Collaborator
There was a problem hiding this comment.
What do these indices refer to?
| function OS.backward_sync_external!(outer_integrator::OS.OperatorSplittingIntegrator, inner_integrator::DiffEqBase.DEIntegrator, sync::ElectroMechanicalSynchronizer) # Tying holds a buffer for the 3D problem with some meta information about the 0D problem | ||
| u_mech_flat = inner_integrator.u | ||
| u_mech = sync.cache.u_mech | ||
| dim = Ferrite.getrefdim(Ferrite.getfieldinterpolation(inner_integrator.f.dh, (1,1))) |
Collaborator
There was a problem hiding this comment.
Can we relax this to not query the first sdh?
| ∇u_mech.data .= Ref(diagm(Tensor{2,dim}, 1.0)) .+ ∇u_mech.data | ||
| I4_mech = sync.cache.I4_mech | ||
| proj = L2Projector(dh.grid) | ||
| for sdh in dh.subdofhandlers |
Collaborator
There was a problem hiding this comment.
Can we query the relevant subdofhandlers here?
| end | ||
| I4_vecs = sync.cache.I4_vecs | ||
| cell_idx = 1 | ||
| for sdh in dh.subdofhandlers |
Collaborator
There was a problem hiding this comment.
Can we query the relevant subdofhandlers here?
| function OS.forward_sync_external!(outer_integrator::OS.OperatorSplittingIntegrator, inner_integrator::DiffEqBase.DEIntegrator, sync::ElectroMechanicalSynchronizer) | ||
| # Tying holds a buffer for the 3D problem with some meta information about the 0D problem | ||
| calcium_field_coeff = inner_integrator.cache.inner_solver_cache.op.integrator.volume_model.material_model.contraction_model.calcium_field | ||
| calcium_state_idx = get_calcium_state_idx(outer_integrator.subintegrator_tree[1][2].f.ode) |
Collaborator
There was a problem hiding this comment.
Can we query the indices from sync?
| function ElectroMechanicalSynchronizer(transfer_op_EP_Mech, transfer_op_Mech_EP) | ||
| qrc=Thunderbolt.QuadratureRuleCollection(1) | ||
| dh = transfer_op_EP_Mech.dh_to # mechanical dh | ||
| dim = Ferrite.getrefdim(Ferrite.getfieldinterpolation(dh, (1,1))) |
Collaborator
There was a problem hiding this comment.
Can we relax this to not query the first sdh?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.