Skip to content

add abstract types for views and permuted arrays #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2025
Merged

add abstract types for views and permuted arrays #255

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c900f07
add abstract types
tiemvanderdeure Apr 10, 2025
15557d1
replace a.v with subarray function
tiemvanderdeure Apr 22, 2025
223bd72
add AbstractReshapedDiskArray
tiemvanderdeure Apr 22, 2025
be71674
fix reshapeddiskarray docstring
tiemvanderdeure Apr 22, 2025
5d7af26
replace field access with function calls for permuteddiskarray
tiemvanderdeure Apr 22, 2025
dffe216
Merge branch 'main' into abstract_types
rafaqz May 6, 2025
aa47a28
import genperm
tiemvanderdeure May 30, 2025
f1ee107
more type parameters in AbstractPermutedDiskArray
tiemvanderdeure May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/permute.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ struct PermutedDiskArray{T,N,P<:PermutedDimsArray{T,N}} <: AbstractPermutedDiskA
end

# Base methods
Base.size(a::AbstractPermutedDiskArray) = size(a.a)
Base.parent(a::AbstractPermutedDiskArray) = a.a.parent
permuteddimsarray(a) = a.a
Base.size(a::AbstractPermutedDiskArray) = size(permuteddimsarray(a))
Base.parent(a::AbstractPermutedDiskArray) = parent(permuteddimsarray(a))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge my other PR first, it actually changes this so there is no separate array. Maybe thats a problem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#249

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think that's a problem at all! The permuteddimsarray was only necessary to get the perm and iperm anyway.

# DiskArrays interface

haschunks(a::AbstractPermutedDiskArray) = haschunks(parent(a))
Expand All @@ -43,10 +44,10 @@ function DiskArrays.writeblock!(a::AbstractPermutedDiskArray, v, i::OrdinalRange
return nothing
end

_getperm(a::AbstractPermutedDiskArray) = _getperm(a.a)
_getperm(a::AbstractPermutedDiskArray) = _getperm(permuteddimsarray(a))
_getperm(::PermutedDimsArray{<:Any,<:Any,perm}) where {perm} = perm

_getiperm(a::AbstractPermutedDiskArray) = _getiperm(a.a)
_getiperm(a::AbstractPermutedDiskArray) = _getiperm(permuteddimsarray(a))
_getiperm(::PermutedDimsArray{<:Any,<:Any,<:Any,iperm}) where {iperm} = iperm

# Implementaion macros
Expand Down
Loading