Skip to content

fix runtime issue of IOBuffer backend #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonasIsensee merged 1 commit into from
Nov 27, 2025
+9 −11
Merged

fix runtime issue of IOBuffer backend #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/io/bufferedio.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ Base.show(io::IO, ::BufferedReader) = print(io, "BufferedReader")

function readmore!(io::BufferedReader, n::Integer)
f = io.f
amount = max(bytesavailable(f), n) #TODO: check if this reads way to much
sz = _getsize(f)
amount = min(max(n, 2^14), sz-position(f))
amount < n && throw(EOFError())
buffer = io.buffer
pos = bufferpos(io)
Expand Down
17 changes: 7 additions & 10 deletions src/io/io_wrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,17 +172,14 @@ Base.isreadable(::RWBuffer) = true
Base.iswritable(::RWBuffer) = true
isseekable(::RWBuffer) = true

_getsize(io::RWBuffer) = io.size

function _getsize(io::IO)
try
return filesize(io)
catch
# fallback
pos = position(io)
seekend(io)
sz = position(io)
seek(io, pos)
return sz
end
pos = position(io)
seekend(io)
sz = position(io)
seek(io, pos)
return sz
end

###########################################################################################
Expand Down
Loading