Skip to content

Support saving AbstractArray as mat file #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2025
Merged

Support saving AbstractArray as mat file #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5192b0b
Support saving AbstractArray as mat file
ZhuWenhao-88 Jun 6, 2025
d919989
Improve the test case
ZhuWenhao-88 Jun 6, 2025
ffa7272
add gitlab ci
Jun 9, 2025
3192f97
Support saving AbstractArray as mat file
ZhuWenhao-88 Jun 6, 2025
b7458f3
Improve the test case
ZhuWenhao-88 Jun 6, 2025
41e2306
Merge branch 'master' of https://github.com/ZhuWenhao-88/MAT.jl
ZhuWenhao-88 Jun 9, 2025
b3031bc
remove unexpected file
ZhuWenhao-88 Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/MAT_HDF5.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,19 @@ function m_writearray(parent::HDF5Parent, name::String, adata::AbstractArray{Com
end
end

function _normalize_arr(x)
if x isa Array
x
elseif x isa AbstractArray
collect(x)
else
x
end
end

# Write a scalar or array
function m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, data::Union{T, Complex{T}, Array{T}, Array{Complex{T}}}) where {T<:HDF5BitsOrBool}
function m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, data::Union{T, Complex{T}, AbstractArray{T}, AbstractArray{Complex{T}}}) where {T<:HDF5BitsOrBool}
data = _normalize_arr(data)
if isempty(data)
m_writeempty(parent, name, data)
return
Expand Down Expand Up @@ -443,7 +454,8 @@ function m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, str::A
end

# Write cell arrays
function m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, data::Array{T}) where T
function m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, data::AbstractArray{T}) where T
data = _normalize_arr(data)
pathrefs = "/#refs#"
fid = HDF5.file(parent)
local g
Expand Down
7 changes: 7 additions & 0 deletions test/write.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,10 @@ test_write(sd)
# note: compression is NOT effective when the dict contains many duplicate entries
# which are not compressible by themselves!
test_compression_effective(Dict("data" => fill(1.0, 1000)))

# test adjoint/reshape array
test_write(Dict("adjoint_arr"=>[1 2 3;4 5 6;7 8 9]'))
test_write(Dict("reshape_arr"=>reshape([1 2 3;4 5 6;7 8 9]',1,9)))

test_write(Dict("adjoint_arr"=>Any[1 2 3;4 5 6;7 8 9]'))
test_write(Dict("reshape_arr"=>reshape(Any[1 2 3;4 5 6;7 8 9]',1,9)))
Loading