Skip to content

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Mar 5, 2025

It looks like strings and datetimes are not supported in zarr-python 3 yet: zarr-developers/zarr-python#2617 zarr-developers/zarr-python#2347 zarr-developers/zarr-python#2616

Maybe it makes sense to remove these types from the zarr-python compatibility tests.

@nhz2 nhz2 changed the title Try updating to zarr-python 3 Try updating tests to zarr-python 3 Mar 5, 2025
@coveralls
Copy link

coveralls commented Mar 5, 2025

Pull Request Test Coverage Report for Build 13682974461

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-1.6%) to 84.47%

Files with Coverage Reduction New Missed Lines %
src/Filters/vlenfilters.jl 1 95.56%
src/Storage/Storage.jl 1 76.92%
src/ZArray.jl 1 92.02%
src/Filters/Filters.jl 3 50.0%
src/Compressors/zlib.jl 5 54.55%
src/metadata.jl 7 71.26%
Totals Coverage Status
Change from base Build 13680422725: -1.6%
Covered Lines: 892
Relevant Lines: 1056

💛 - Coveralls


# Test reading in python
for julia_path in (pjulia, pjulia*".zip")
g = zarr.open_group(julia_path)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change can be reverted once a bug in zarr-python is fixed. zarr-developers/zarr-python#2856

@lazarusA lazarusA mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants