Skip to content

Conversation

felixcremer
Copy link
Contributor

This would hopefully get rid of the following warning in julia 1.12

 ┌ Zarr
│  WARNING: Constructor for type "UInt8" was extended in `Zarr` without explicit qualification or import.
│    NOTE: Assumed "UInt8" refers to `Base.UInt8`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function UInt8 end`.
│    Hint: To silence the warning, qualify `UInt8` as `Base.UInt8` in the method signature or explicitly `import Base: UInt8`.

@mkitti
Copy link
Member

mkitti commented May 8, 2025

I slipped a commit like this into #182 , but yes, doing this independently is best.

@coveralls
Copy link

coveralls commented May 8, 2025

Pull Request Test Coverage Report for Build 14908265411

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 85.957%

Totals Coverage Status
Change from base Build 13680422725: -0.08%
Covered Lines: 912
Relevant Lines: 1061

💛 - Coveralls

@mkitti mkitti self-requested a review May 12, 2025 17:13
Copy link
Member

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nhz2 nhz2 merged commit d39d6de into JuliaIO:master Jun 4, 2025
14 of 17 checks passed
@felixcremer felixcremer deleted the fc/uint8 branch June 4, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants